test_runner: fix coverage report when --enable-source-maps is provided #55228

geeksilva97 · 2024-10-01T21:28:37Z

Refs: #55106 #54753

nodejs-github-bot · 2024-10-01T21:28:43Z

Review requested:

@nodejs/test_runner

avivkeller · 2024-10-01T21:35:59Z

I bring with me my concerns from the other PR, but I'm curious what others think

geeksilva97 · 2024-10-01T21:47:43Z

I bring with me my concerns from the other PR, but I'm curious what others think

Now I see what you meant. I will dig into it.

lib/internal/test_runner/test.js

test/parallel/test-runner-coverage-source-map.js

codecov · 2024-10-05T19:18:01Z

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (deb5eff) to head (6391e6e).
Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/coverage.js	44.44%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55228      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      652              
  Lines      186756   186785      +29     
  Branches    36100    36101       +1     
==========================================
- Hits       165126   165119       -7     
- Misses      14906    14931      +25     
- Partials     6724     6735      +11

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	`63.82% <44.44%> (-0.83%)`	⬇️

... and 33 files with indirect coverage changes

geeksilva97 · 2024-10-05T20:09:50Z

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (98788da) to head (c0deb06).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/coverage.js 44.44% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55228      +/-   ##
==========================================
+ Coverage   87.89%   88.40%   +0.51%     
==========================================
  Files         652      652              
  Lines      186589   186638      +49     
  Branches    35750    36054     +304     
==========================================
+ Hits       163999   165003    +1004     
+ Misses      15816    14904     -912     
+ Partials     6774     6731      -43     
Files with missing lines Coverage Δ
lib/internal/test_runner/coverage.js 63.86% <44.44%> (-0.83%) ⬇️
... and 96 files with indirect coverage changes

how's this possible?

avivkeller · 2024-10-06T18:22:00Z

how's this possible?

In my experience, codecov isn't always exactly accurate. Regardless, it's nothing to be concerned about.

nodejs-github-bot · 2024-10-06T18:26:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62948/

nodejs-github-bot · 2024-10-07T05:49:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62958/

avivkeller · 2024-10-07T15:47:56Z

EDIT: on CI, mine fails. Not sure what caused that.

If you can reproduce the failure locally, it might help to have it log the output to see what the actual difference is.

geeksilva97 · 2024-10-07T15:52:46Z

EDIT: on CI, mine fails. Not sure what caused that.

If you can reproduce the failure locally, it might help to have it log the output to see what the actual difference is.

It's the assertion on stdout

TAP version 13
# Subtest: /Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/invalid-json/index.js
ok 1 - /Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/invalid-json/index.js
  ---
  duration_ms: 38.544167
  ...
1..1
# Warning: Could not report code coverage. TypeError: Cannot read properties of null (reading 'sourcesContent')
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 43.42

this message is not being printed.

When I run ./node --test --experimental-test-coverage --test-reporter tap test/fixtures/test-runner/source-maps/missing-sources/index.js it prints the message though.

TAP version 13
# Subtest: test/fixtures/test-runner/source-maps/missing-sources/index.js
ok 1 - test/fixtures/test-runner/source-maps/missing-sources/index.js
  ---
  duration_ms: 301.77525
  ...
1..1
# Warning: Could not report code coverage. Error [ERR_SOURCE_MAP_MISSING_SOURCE]: Cannot find 'file:///Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/missing-sources/nonexistent.js' imported from the source map for 'file:///Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/missing-sources/index.js'
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 305.851208

Sorry @redyetidev . Newbie working. I think I need to recompile

avivkeller · 2024-10-07T15:59:20Z

Try rebasing to include your other PR?

nodejs-github-bot · 2024-10-08T14:17:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62991/

nodejs-github-bot · 2024-10-08T19:55:56Z

Landed in 3a42085

cjihrig · 2024-10-08T19:57:25Z

This Refs two issues. Does it actually fix either/both of them?

geeksilva97 · 2024-10-08T20:00:34Z

This Refs two issues. Does it actually fix either/both of them?

I'd say yes. I'm pretty sure it solves #54753. Could you confirm for #55106 @redyetidev ?

avivkeller · 2024-10-08T20:03:23Z

There aren't any tests to confirm that, can you no longer reproduce the errors described? I would assume your other PR fixes that one

test/parallel/test-runner-coverage-source-map.js

PR-URL: #55228 Refs: #55106 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#55228 Refs: nodejs#55106 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 1, 2024

geeksilva97 mentioned this pull request Oct 1, 2024

test_runner: ignore unmapped lines for coverage #55162

Closed

geeksilva97 changed the title ~~Issue 55106~~ test_runner: fix coverage report when --enable-source-maps is provide Oct 1, 2024

geeksilva97 changed the title ~~test_runner: fix coverage report when --enable-source-maps is provide~~ test_runner: fix coverage report when --enable-source-maps is provided Oct 1, 2024

cjihrig reviewed Oct 1, 2024

View reviewed changes

lib/internal/test_runner/test.js Outdated Show resolved Hide resolved

geeksilva97 mentioned this pull request Oct 2, 2024

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

Merged

geeksilva97 force-pushed the issue-55106 branch from 4b1fa1f to c8bd13f Compare October 2, 2024 15:17

geeksilva97 marked this pull request as ready for review October 5, 2024 17:11

geeksilva97 force-pushed the issue-55106 branch from c8bd13f to 67517de Compare October 5, 2024 17:17

geeksilva97 requested a review from cjihrig October 5, 2024 17:48

MoLow reviewed Oct 5, 2024

View reviewed changes

test/parallel/test-runner-coverage-source-map.js Outdated Show resolved Hide resolved

MoLow approved these changes Oct 5, 2024

View reviewed changes

geeksilva97 force-pushed the issue-55106 branch from c0deb06 to 51c8f37 Compare October 5, 2024 20:12

atlowChemi approved these changes Oct 6, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2024

geeksilva97 added 2 commits October 7, 2024 10:43

test_runner: ignore unmapped lines for coverage

f44115f

test: coverage report with --enable-source-maps

1157465

geeksilva97 force-pushed the issue-55106 branch from 51c8f37 to ed3668e Compare October 7, 2024 13:44

test: update enable-source-maps coverage test

6391e6e

geeksilva97 force-pushed the issue-55106 branch from ed3668e to 6391e6e Compare October 7, 2024 16:27

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

geeksilva97 requested review from MoLow and atlowChemi October 8, 2024 15:46

atlowChemi approved these changes Oct 8, 2024

View reviewed changes

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024

nodejs-github-bot merged commit 3a42085 into nodejs:main Oct 8, 2024
59 checks passed

avivkeller reviewed Oct 9, 2024

View reviewed changes

test/parallel/test-runner-coverage-source-map.js Show resolved Hide resolved

This was referenced Oct 9, 2024

Revert "test_runner: ignore unmapped lines for coverage" #55339

Merged

2024-10-16, Version 23.0.0 (Current) #55338

Merged

aduh95 pushed a commit that referenced this pull request Oct 9, 2024

test_runner: ignore unmapped lines for coverage

3503658

PR-URL: #55228 Refs: #55106 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 9, 2024

avivkeller added dont-land-on-v23.x and removed dont-land-on-v23.x labels Oct 10, 2024

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

test_runner: ignore unmapped lines for coverage

863b0af

PR-URL: nodejs#55228 Refs: nodejs#55106 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

test_runner: ignore unmapped lines for coverage

8b4c918

PR-URL: nodejs#55228 Refs: nodejs#55106 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

Uh oh!

test_runner: fix coverage report when --enable-source-maps is provided #55228

test_runner: fix coverage report when --enable-source-maps is provided #55228

Uh oh!

Conversation

geeksilva97 commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 1, 2024

Uh oh!

avivkeller commented Oct 1, 2024

Uh oh!

geeksilva97 commented Oct 1, 2024

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geeksilva97 commented Oct 5, 2024

Codecov Report

Uh oh!

avivkeller commented Oct 6, 2024

Uh oh!

nodejs-github-bot commented Oct 6, 2024

Uh oh!

nodejs-github-bot commented Oct 7, 2024

Uh oh!

avivkeller commented Oct 7, 2024

Uh oh!

geeksilva97 commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Oct 7, 2024

Uh oh!

nodejs-github-bot commented Oct 8, 2024

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 8, 2024

Uh oh!

cjihrig commented Oct 8, 2024

Uh oh!

geeksilva97 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

geeksilva97 commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 5, 2024 •

edited

Loading

geeksilva97 commented Oct 7, 2024 •

edited

Loading

geeksilva97 commented Oct 8, 2024 •

edited

Loading

avivkeller commented Oct 8, 2024 •

edited

Loading